Merge branch 'fix-excessive-reregistrations' into 'develop'

Fix rogue nested watcher triggering notifications registering too often

Closes #1159

See merge request pleroma/pleroma-fe!1708
This commit is contained in:
HJ 2022-12-22 13:15:46 +00:00
commit eae62e2eb8
2 changed files with 6 additions and 9 deletions

View file

@ -41,7 +41,13 @@ export default {
},
methods: {
update (e) {
const [firstSegment, ...rest] = this.path.split('.')
set(this.$parent, this.path, e)
// Updating nested properties does not trigger update on its parent.
// probably still not as reliable, but works for depth=1 at least
if (rest.length > 0) {
set(this.$parent, firstSegment, { ...get(this.$parent, firstSegment) })
}
},
reset () {
set(this.$parent, this.path, this.defaultState)

View file

@ -38,15 +38,6 @@ const FilteringTab = {
},
// Updating nested properties
watch: {
notificationVisibility: {
handler (value) {
this.$store.dispatch('setOption', {
name: 'notificationVisibility',
value: this.$store.getters.mergedConfig.notificationVisibility
})
},
deep: true
},
replyVisibility () {
this.$store.dispatch('queueFlushAll')
}