sam/pleroma-fe
sam/pleroma-fe
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix emoji processor not leaving string as-is if no emoji are found

Browse source
This commit is contained in:
Henry Jameson 2021-06-07 12:38:27 +03:00 committed by Sam Therapy
parent 971ab94261
commit c703945350
Signed by: sam
GPG key ID: 4D8B07C18F31ACBD
2 changed files with 29 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/services/mini_html_converter/mini_html_converter.service.js
View file

@ -118,6 +118,7 @@ export const processTextForEmoji = (text, emojis, processor) => {
textBuffer += char
}
}
if (textBuffer) buffer.push(textBuffer)
return buffer
}

29
test/unit/specs/services/tiny_post_html_processor/mini_post_html_processor.spec.js
View file

@ -57,7 +57,7 @@ describe('MiniHtmlConverter', () => {
]
])
})
it('realistic case', () => {
it('realistic case 1', () => {
const inputOutput = '<p><span class="h-card"><a class="u-url mention" data-user="9wRC6T2ZZiKWJ0vUi8" href="https://cawfee.club/users/benis" rel="ugc">@<span>benis</span></a></span> <span class="h-card"><a class="u-url mention" data-user="194" href="https://shigusegubu.club/users/hj" rel="ugc">@<span>hj</span></a></span> nice</p>'
expect(convertHtml(inputOutput)).to.eql([
[
@ -110,6 +110,24 @@ describe('MiniHtmlConverter', () => {
]
])
})
it('realistic case 2', () => {
const inputOutput = 'Country improv: give me a city<br/>Audience: Memphis<br/>Improv troupe: come on, a better one<br/>Audience: el paso'
expect(convertHtml(inputOutput)).to.eql([
'Country improv: give me a city',
[
'<br/>'
],
'Audience: Memphis',
[
'<br/>'
],
'Improv troupe: come on, a better one',
[
'<br/>'
],
'Audience: el paso'
])
})
})
describe('processTextForEmoji', () => {
it('processes all emoji in text', () => {
@ -126,5 +144,14 @@ describe('MiniHtmlConverter', () => {
{ shortcode: 'lmao', src: 'LMAO' }
])
})
it('leaves text as is', () => {
const inputOutput = 'Number one: that\'s terror'
const emojis = []
const processor = ({ shortcode, src }) => ({ shortcode, src })
expect(processTextForEmoji(inputOutput, emojis, processor)).to.eql([
'Number one: that\'s terror'
])
})
})
})
})