sam/awl
sam/awl
1
0
Fork 1
Code Issues 5 Pull requests Projects Releases 28 Packages 4 Wiki Activity Actions

refactor of query.go #27

Merged
sam merged 4 commits from refactor into master 2022-07-03 20:45:12 +00:00
Conversation 0 Commits 4 Files changed 9 +291 -150
grumbulon commented 2022-07-03 20:40:34 +00:00
Collaborator
Copy link

This breaks query.go into a more modular way of working by implementing the Resolver interface for DoH and DoQ requests (and more in the future if necessary), allows logging to be performed anywhere the new Options struct is passed, refactors all tests to work with new interface, and includes a fix for #26

This breaks query.go into a more modular way of working by implementing the `Resolver` interface for DoH and DoQ requests (and more in the future if necessary), allows logging to be performed anywhere the new `Options` struct is passed, refactors all tests to work with new interface, and includes a fix for #26
grumbulon added 4 commits 2022-07-03 20:40:35 +00:00
more debug logging and adding dns msg flags back in using opts struct
All checks were successful
continuous-integration/drone/push Build is passing
Details
15658f3aee
Merge remote-tracking branch 'origin/master' into refactor
All checks were successful
continuous-integration/drone/push Build is passing
Details
70f8e942ca
Preliminary fix for #26
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
e709b71f4e 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam approved these changes 2022-07-03 20:44:42 +00:00
sam merged commit ed4d74bb96 into master 2022-07-03 20:45:12 +00:00
sam deleted branch refactor 2022-07-03 20:45:12 +00:00
sam referenced this pull request from a commit 2022-07-03 20:45:13 +00:00
refactor of query.go (#27)
Sign in to join this conversation.
Reviewers
No reviewers
sam
Labels
Clear labels   
Priority: High

This should be worked on soon

  
Priority: Low

This might get worked on

  
Priority: Medium

This should be worked on eventually

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

I am too lazy to do this myself but I will gladly look at someone else's effort

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
Priority: High
Priority: Low
Priority: Medium
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sam/awl#27
No description provided.
Delete branch "refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?