sam/awl
sam
/
awl
1
0
Fork 1
Code Issues 5 Pull Requests Actions Packages Projects Releases 27 Wiki Activity

chore(Refactor) #110

Merged
grumbulon merged 15 commits from refactor into master 2022-09-24 23:11:10 +00:00
Conversation 0 Commits 15 Files Changed 39 +162 -161
grumbulon commented 2022-09-22 23:40:21 +00:00
Collaborator
Copy Link
  1. Describe what your pull request does and which issue you're targeting (if any)

This refactor serves mainly three purposes, group like functions together, move certain functions from one package to another that makes more sense, ensure all functions under the LookUp interface are readable and consistent with this style guide, and moving all library-like packages under the pkg directory for consistency based off this guide.

1. Describe what your pull request does and which issue you're targeting (if any) This refactor serves mainly three purposes, group like functions together, move certain functions from one package to another that makes more sense, ensure all functions under the `LookUp` interface are readable and consistent with [this style guide](https://github.com/uber-go/guide/blob/master/style.md), and moving all library-like packages under the pkg directory for consistency based off [this guide](https://github.com/golang-standards/project-layout#go-directories).
grumbulon added 10 commits 2022-09-22 23:40:21 +00:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
b9abedfca2
API work 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
continuous-integration/drone/push Build is failing Details
faa8ac55f2 merge master into refactor
continuous-integration/drone/push Build is failing Details
323a99b652 wrapcheck fix
continuous-integration/drone/push Build is passing Details
20f9cd0c4f test
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is running Details
3eb2955bcf merge master into this shit
grumbulon added 1 commit 2022-09-22 23:41:56 +00:00
continuous-integration/drone/push Build is failing Details
continuous-integration/drone/pr Build is failing Details
fa05b3c699 change cli dir to cmd, update path in main.go
grumbulon added 1 commit 2022-09-22 23:43:12 +00:00
continuous-integration/drone/push Build is failing Details
continuous-integration/drone/pr Build is failing Details
862b910123 oops
grumbulon added 1 commit 2022-09-22 23:45:34 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
085324758e hardcoding stuff is good actually
grumbulon requested review from sam 2022-09-22 23:46:37 +00:00
sam added 1 commit 2022-09-24 22:51:52 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
65acc87a8c
Merge branch 'master' into refactor 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam requested changes 2022-09-24 22:56:19 +00:00
sam left a comment
Owner
Copy Link

Besides the one nitpick everything else looks good!

Besides the one nitpick everything else looks good!
pkg/util/query.go Outdated
sam commented 2022-09-24 22:55:49 +00:00
Owner
Copy Link

Any reason why these are getting removed?

Any reason why these are getting removed?
grumbulon commented 2022-09-24 22:58:29 +00:00
Author
Collaborator
Copy Link

Probably just an issue with the merge conflict since the diff file didn't work so I had to do it manually, I will re-add it.

Probably just an issue with the merge conflict since the diff file didn't work so I had to do it manually, I will re-add it.
👍 1 ❤️ 1
grumbulon added 1 commit 2022-09-24 23:02:12 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
fb483b70bd re-add lost stuff in previous rebase
sam approved these changes 2022-09-24 23:02:45 +00:00
sam left a comment
Owner
Copy Link

LGTM

LGTM
🎉 1
grumbulon merged commit 3a0a8f015a into master 2022-09-24 23:11:10 +00:00
grumbulon deleted branch refactor 2022-09-24 23:11:10 +00:00
grumbulon referenced this issue from a commit 2022-09-24 23:11:10 +00:00
chore(Refactor) (#110)
Sign in to join this conversation.
Reviewers
No reviewers
sam
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

I am too lazy to do this myself but I will gladly look at someone else's effort

  
invalid

Something is wrong

  
Priority: High

This should be worked on soon

  
Priority: Low

This might get worked on

  
Priority: Medium

This should be worked on eventually

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
Priority: High
Priority: Low
Priority: Medium
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sam/awl#110
No description provided.
Delete Branch "refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?