sam/awl
sam/awl
1
0
Fork 1
Code Issues 5 Pull requests Projects Releases 28 Packages 4 Wiki Activity Actions

refactor: Make tests less ugly #102

Merged
sam merged 12 commits from refactor-tests-pretty into master 2022-09-21 23:08:32 +00:00
Conversation 1 Commits 12 Files changed 16 +522 -474
sam commented 2022-09-16 23:44:24 +00:00
Owner
Copy link

Merge #101 first

Merge #101 first
sam added a new dependency 2022-09-16 23:45:05 +00:00
#101 fix: remove race conditions with flags
sam force-pushed refactor-tests-pretty from 729d1ee364 to f9cf298e50 2022-09-16 23:45:21 +00:00 Compare
sam force-pushed refactor-tests-pretty from bbefa25de9 to 0ec619f661 2022-09-17 10:59:41 +00:00 Compare
sam commented 2022-09-17 11:03:56 +00:00
Author
Owner
Copy link

These CI failures are extremely annoying (an unrelated to this PR), I wonder how they can be fixed

These CI failures are extremely annoying (an unrelated to this PR), I wonder how they can be fixed
sam added 4 commits 2022-09-21 12:07:41 +00:00
refactor: make more tests table driven
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
8a3afa261a 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
grumbulon requested changes 2022-09-21 21:19:36 +00:00
conf/plan9_test.go Outdated
@ -49,3 +27,1 @@
bootf=/mips/9powerboot
ip=135.104.117.32 ether=080069020677
proto=il`
// Old config grabber tests
grumbulon commented 2022-09-21 20:59:18 +00:00
Collaborator
Copy link

Remove old tests unless you expect to convert them to be table driven like the new ones

Remove old tests unless you expect to convert them to be table driven like the new ones
sam marked this conversation as resolved
sam added 4 commits 2022-09-21 22:59:59 +00:00
Code review :)
Some checks reported errors
continuous-integration/drone/push Build was killed
Details
continuous-integration/drone/pr Build is failing
Details
b3485924d6 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam added 1 commit 2022-09-21 23:03:33 +00:00
maybe fix merge conflict?
Some checks reported errors
continuous-integration/drone/pr Build was killed
Details
continuous-integration/drone/push Build was killed
Details
4fcff687ee 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam added 1 commit 2022-09-21 23:03:54 +00:00
Merge branch 'master' into refactor-tests-pretty
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
549716eb27
sam requested review from grumbulon 2022-09-21 23:04:11 +00:00
grumbulon approved these changes 2022-09-21 23:07:02 +00:00
sam merged commit 0845ae2a82 into master 2022-09-21 23:08:32 +00:00
sam deleted branch refactor-tests-pretty 2022-09-21 23:08:32 +00:00
sam referenced this pull request from a commit 2022-09-21 23:08:32 +00:00
refactor: Make tests less ugly (#102)
Sign in to join this conversation.
Reviewers
No reviewers
grumbulon
Labels
Clear labels   
Priority: High

This should be worked on soon

  
Priority: Low

This might get worked on

  
Priority: Medium

This should be worked on eventually

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

I am too lazy to do this myself but I will gladly look at someone else's effort

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
Priority: High
Priority: Low
Priority: Medium
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on
#101 fix: remove race conditions with flags
sam/awl
Reference: sam/awl#102
No description provided.
Delete branch "refactor-tests-pretty"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?