chore(Refactor) #110

Merged

grumbulon merged 15 commits from refactor into master 2022-09-24 23:11:10 +00:00

Conversation 0 Commits 15 Files changed 39 +162 -161

grumbulon commented 2022-09-22 23:40:21 +00:00

Collaborator

Copy link

1. Describe what your pull request does and which issue you're targeting (if any)

This refactor serves mainly three purposes, group like functions together, move certain functions from one package to another that makes more sense, ensure all functions under the LookUp interface are readable and consistent with this style guide, and moving all library-like packages under the pkg directory for consistency based off this guide.

1. Describe what your pull request does and which issue you're targeting (if any) This refactor serves mainly three purposes, group like functions together, move certain functions from one package to another that makes more sense, ensure all functions under the `LookUp` interface are readable and consistent with [this style guide](https://github.com/uber-go/guide/blob/master/style.md), and moving all library-like packages under the pkg directory for consistency based off [this guide](https://github.com/golang-standards/project-layout#go-directories).

grumbulon added 10 commits 2022-09-22 23:40:21 +00:00

API work ... b9abedfca2

Signed-off-by: Sam Therapy <sam@samtherapy.net>

move files into more appropriate packages and into pkg directory 288a409fc1

logawl cleanup 790529267a

resolver receiever consistency 80e7ded4fb

merge master into refactor faa8ac55f2

wrapcheck fix 323a99b652

WARN [linter] revive: the following rules (context-keys-type,errorf,modifies-value-receiver,time-naming,unexported-return,var-declaration) 7b3b9eeb53

Merge remote-tracking branch 'origin' into refactor 627bb6b36e

test 20f9cd0c4f

merge master into this shit 3eb2955bcf

grumbulon added 1 commit 2022-09-22 23:41:56 +00:00

change cli dir to cmd, update path in main.go fa05b3c699

grumbulon added 1 commit 2022-09-22 23:43:12 +00:00

oops 862b910123

grumbulon added 1 commit 2022-09-22 23:45:34 +00:00

hardcoding stuff is good actually 085324758e

grumbulon requested review from sam 2022-09-22 23:46:37 +00:00

sam added 1 commit 2022-09-24 22:51:52 +00:00

Merge branch 'master' into refactor ... 65acc87a8c

Signed-off-by: Sam Therapy <sam@samtherapy.net>

sam requested changes 2022-09-24 22:56:19 +00:00

sam left a comment

Owner

Copy link

Besides the one nitpick everything else looks good!

Besides the one nitpick everything else looks good!

pkg/util/query.go Outdated

Show outdated Hide outdated

sam commented 2022-09-24 22:55:49 +00:00

Owner

Copy link

Any reason why these are getting removed?

Any reason why these are getting removed?

grumbulon commented 2022-09-24 22:58:29 +00:00

Author

Collaborator

Copy link

Probably just an issue with the merge conflict since the diff file didn't work so I had to do it manually, I will re-add it.

Probably just an issue with the merge conflict since the diff file didn't work so I had to do it manually, I will re-add it.

👍 1 ❤️ 1

grumbulon added 1 commit 2022-09-24 23:02:12 +00:00

re-add lost stuff in previous rebase fb483b70bd

sam approved these changes 2022-09-24 23:02:45 +00:00

sam left a comment

Owner

Copy link

LGTM

LGTM

🎉 1

grumbulon merged commit 3a0a8f015a into master 2022-09-24 23:11:10 +00:00

grumbulon deleted branch refactor 2022-09-24 23:11:10 +00:00

grumbulon referenced this pull request from a commit 2022-09-24 23:11:10 +00:00

chore(Refactor) (#110)

Sign in to join this conversation.

Reviewers

No reviewers

sam

Labels

Clear labels   

Priority: High

This should be worked on soon

  

Priority: Low

This might get worked on

  

Priority: Medium

This should be worked on eventually

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

I am too lazy to do this myself but I will gladly look at someone else's effort

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

Priority: High

Priority: Low

Priority: Medium

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sam/awl#110

No description provided.