f3e061c964
30 to 70% of the objects in the object table are simple JSON objects containing a single field, 'id', being the context's ID. The reason for the creation of an object per context seems to be an old relic from the StatusNet era, and has only been used nowadays as an helper for threads in Pleroma-FE via the `pleroma.conversation_id` field in status views. An object per context was created, and its numerical ID (table column) was used and stored as 'context_id' in the object and activity along with the full 'context' URI/string. This commit removes this field and stops creation of objects for each context, which will also allow incoming activities to use activity IDs as contexts, something which was not possible before, or would have been very broken under most circumstances. The `pleroma.conversation_id` field has been reimplemented in a way to maintain backwards-compatibility by calculating a CRC32 of the full context URI/string in the object, instead of relying on the row ID for the created context object.
77 lines
2.5 KiB
Elixir
77 lines
2.5 KiB
Elixir
# Pleroma: A lightweight social networking server
|
|
# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
defmodule Pleroma.Web.ActivityPub.ObjectValidators.CommonFixes do
|
|
alias Pleroma.EctoType.ActivityPub.ObjectValidators
|
|
alias Pleroma.Object
|
|
alias Pleroma.Object.Containment
|
|
alias Pleroma.User
|
|
alias Pleroma.Web.ActivityPub.Transmogrifier
|
|
alias Pleroma.Web.ActivityPub.Utils
|
|
|
|
def cast_and_filter_recipients(message, field, follower_collection, field_fallback \\ []) do
|
|
{:ok, data} = ObjectValidators.Recipients.cast(message[field] || field_fallback)
|
|
|
|
data =
|
|
Enum.reject(data, fn x ->
|
|
String.ends_with?(x, "/followers") and x != follower_collection
|
|
end)
|
|
|
|
Map.put(message, field, data)
|
|
end
|
|
|
|
def fix_object_defaults(data) do
|
|
context = Utils.maybe_create_context(data["context"] || data["conversation"])
|
|
|
|
%User{follower_address: follower_collection} = User.get_cached_by_ap_id(data["attributedTo"])
|
|
|
|
data
|
|
|> Map.put("context", context)
|
|
|> cast_and_filter_recipients("to", follower_collection)
|
|
|> cast_and_filter_recipients("cc", follower_collection)
|
|
|> cast_and_filter_recipients("bto", follower_collection)
|
|
|> cast_and_filter_recipients("bcc", follower_collection)
|
|
|> Transmogrifier.fix_implicit_addressing(follower_collection)
|
|
end
|
|
|
|
def fix_activity_addressing(activity) do
|
|
%User{follower_address: follower_collection} = User.get_cached_by_ap_id(activity["actor"])
|
|
|
|
activity
|
|
|> cast_and_filter_recipients("to", follower_collection)
|
|
|> cast_and_filter_recipients("cc", follower_collection)
|
|
|> cast_and_filter_recipients("bto", follower_collection)
|
|
|> cast_and_filter_recipients("bcc", follower_collection)
|
|
|> Transmogrifier.fix_implicit_addressing(follower_collection)
|
|
end
|
|
|
|
def fix_actor(data) do
|
|
actor =
|
|
data
|
|
|> Map.put_new("actor", data["attributedTo"])
|
|
|> Containment.get_actor()
|
|
|
|
data
|
|
|> Map.put("actor", actor)
|
|
|> Map.put("attributedTo", actor)
|
|
end
|
|
|
|
def fix_activity_context(data, %Object{data: %{"context" => object_context}}) do
|
|
data
|
|
|> Map.put("context", object_context)
|
|
end
|
|
|
|
def fix_object_action_recipients(%{"actor" => actor} = data, %Object{data: %{"actor" => actor}}) do
|
|
to = ((data["to"] || []) -- [actor]) |> Enum.uniq()
|
|
|
|
Map.put(data, "to", to)
|
|
end
|
|
|
|
def fix_object_action_recipients(data, %Object{data: %{"actor" => actor}}) do
|
|
to = ((data["to"] || []) ++ [actor]) |> Enum.uniq()
|
|
|
|
Map.put(data, "to", to)
|
|
end
|
|
end
|