Made `Pleroma.Web.MastodonAPI.AccountView.render("show.json", _)` demand :for or :force option in order to prevent incorrect rendering of empty map instead of expected user representation with truish :restrict_unauthenticated setting.
141 lines
4 KiB
Elixir
141 lines
4 KiB
Elixir
# Pleroma: A lightweight social networking server
|
|
# Copyright © 2017-2020 Pleroma Authors <https://pleroma.social/>
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
defmodule Pleroma.Web.AdminAPI.ReportViewTest do
|
|
use Pleroma.DataCase
|
|
|
|
import Pleroma.Factory
|
|
|
|
alias Pleroma.Web.AdminAPI
|
|
alias Pleroma.Web.AdminAPI.Report
|
|
alias Pleroma.Web.AdminAPI.ReportView
|
|
alias Pleroma.Web.CommonAPI
|
|
alias Pleroma.Web.MastodonAPI
|
|
alias Pleroma.Web.MastodonAPI.StatusView
|
|
|
|
test "renders a report" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.report(user, %{account_id: other_user.id})
|
|
|
|
expected = %{
|
|
content: nil,
|
|
actor:
|
|
Map.merge(
|
|
MastodonAPI.AccountView.render("show.json", %{user: user, force: true}),
|
|
AdminAPI.AccountView.render("show.json", %{user: user})
|
|
),
|
|
account:
|
|
Map.merge(
|
|
MastodonAPI.AccountView.render("show.json", %{user: other_user, force: true}),
|
|
AdminAPI.AccountView.render("show.json", %{user: other_user})
|
|
),
|
|
statuses: [],
|
|
notes: [],
|
|
state: "open",
|
|
id: activity.id
|
|
}
|
|
|
|
result =
|
|
ReportView.render("show.json", Report.extract_report_info(activity))
|
|
|> Map.delete(:created_at)
|
|
|
|
assert result == expected
|
|
end
|
|
|
|
test "includes reported statuses" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
{:ok, activity} = CommonAPI.post(other_user, %{status: "toot"})
|
|
|
|
{:ok, report_activity} =
|
|
CommonAPI.report(user, %{account_id: other_user.id, status_ids: [activity.id]})
|
|
|
|
other_user = Pleroma.User.get_by_id(other_user.id)
|
|
|
|
expected = %{
|
|
content: nil,
|
|
actor:
|
|
Map.merge(
|
|
MastodonAPI.AccountView.render("show.json", %{user: user, force: true}),
|
|
AdminAPI.AccountView.render("show.json", %{user: user})
|
|
),
|
|
account:
|
|
Map.merge(
|
|
MastodonAPI.AccountView.render("show.json", %{user: other_user, force: true}),
|
|
AdminAPI.AccountView.render("show.json", %{user: other_user})
|
|
),
|
|
statuses: [StatusView.render("show.json", %{activity: activity})],
|
|
state: "open",
|
|
notes: [],
|
|
id: report_activity.id
|
|
}
|
|
|
|
result =
|
|
ReportView.render("show.json", Report.extract_report_info(report_activity))
|
|
|> Map.delete(:created_at)
|
|
|
|
assert result == expected
|
|
end
|
|
|
|
test "renders report's state" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.report(user, %{account_id: other_user.id})
|
|
{:ok, activity} = CommonAPI.update_report_state(activity.id, "closed")
|
|
|
|
assert %{state: "closed"} =
|
|
ReportView.render("show.json", Report.extract_report_info(activity))
|
|
end
|
|
|
|
test "renders report description" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, activity} =
|
|
CommonAPI.report(user, %{
|
|
account_id: other_user.id,
|
|
comment: "posts are too good for this instance"
|
|
})
|
|
|
|
assert %{content: "posts are too good for this instance"} =
|
|
ReportView.render("show.json", Report.extract_report_info(activity))
|
|
end
|
|
|
|
test "sanitizes report description" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, activity} =
|
|
CommonAPI.report(user, %{
|
|
account_id: other_user.id,
|
|
comment: ""
|
|
})
|
|
|
|
data = Map.put(activity.data, "content", "<script> alert('hecked :D:D:D:D:D:D:D') </script>")
|
|
activity = Map.put(activity, :data, data)
|
|
|
|
refute "<script> alert('hecked :D:D:D:D:D:D:D') </script>" ==
|
|
ReportView.render("show.json", Report.extract_report_info(activity))[:content]
|
|
end
|
|
|
|
test "doesn't error out when the user doesn't exists" do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, activity} =
|
|
CommonAPI.report(user, %{
|
|
account_id: other_user.id,
|
|
comment: ""
|
|
})
|
|
|
|
Pleroma.User.delete(other_user)
|
|
Pleroma.User.invalidate_cache(other_user)
|
|
|
|
assert %{} = ReportView.render("show.json", Report.extract_report_info(activity))
|
|
end
|
|
end
|