Credo
This commit is contained in:
parent
2a47156b87
commit
5f7901cc48
2 changed files with 10 additions and 8 deletions
|
@ -80,10 +80,11 @@ defp build_attachments(%{data: %{"attachment" => attachments}}) do
|
|||
| acc
|
||||
]
|
||||
|
||||
# Not using preview_url for this. It saves bandwidth, but the image dimensions will be wrong.
|
||||
# We generate it on the fly and have no way to capture or analyze the image to get the dimensions.
|
||||
# This can be an issue for apps/FEs rendering images in timelines too, but you can get clever with
|
||||
# the aspect ratio metadata as a workaround.
|
||||
# Not using preview_url for this. It saves bandwidth, but the image dimensions will
|
||||
# be wrong. We generate it on the fly and have no way to capture or analyze the
|
||||
# analyze the image to get the dimensions. This can be an issue for apps/FEs
|
||||
# rendering images in timelines too, but you can get clever with the aspect ratio
|
||||
# metadata as a workaround.
|
||||
"image" ->
|
||||
[
|
||||
{:meta, [property: "og:image", content: MediaProxy.url(url["href"])], []},
|
||||
|
|
|
@ -67,10 +67,11 @@ defp build_attachments(id, %{data: %{"attachment" => attachments}}) do
|
|||
| acc
|
||||
]
|
||||
|
||||
# Not using preview_url for this. It saves bandwidth, but the image dimensions will be wrong.
|
||||
# We generate it on the fly and have no way to capture or analyze the image to get the dimensions.
|
||||
# This can be an issue for apps/FEs rendering images in timelines too, but you can get clever with
|
||||
# the aspect ratio metadata as a workaround.
|
||||
# Not using preview_url for this. It saves bandwidth, but the image dimensions will
|
||||
# be wrong. We generate it on the fly and have no way to capture or analyze the
|
||||
# analyze the image to get the dimensions. This can be an issue for apps/FEs
|
||||
# rendering images in timelines too, but you can get clever with the aspect ratio
|
||||
# metadata as a workaround.
|
||||
"image" ->
|
||||
[
|
||||
{:meta, [property: "twitter:card", content: "summary_large_image"], []},
|
||||
|
|
Loading…
Reference in a new issue