instance.reachable?: Limit to binary input

This commit is contained in:
Haelwenn (lanodan) Monnier 2020-12-07 21:18:51 +01:00
parent e1a2e8b17c
commit 1403798820
No known key found for this signature in database
GPG key ID: D5B7A8E43C997DEE
2 changed files with 4 additions and 4 deletions

View file

@ -77,7 +77,7 @@ def reachable?(url_or_host) when is_binary(url_or_host) do
)
end
def reachable?(_), do: true
def reachable?(url_or_host) when is_binary(url_or_host), do: true
def set_reachable(url_or_host) when is_binary(url_or_host) do
with host <- host(url_or_host),

View file

@ -32,9 +32,9 @@ test "returns `true` for host / url marked unreachable for less than `reachabili
assert Instances.reachable?(URI.parse(url).host)
end
test "returns true on non-binary input" do
assert Instances.reachable?(nil)
assert Instances.reachable?(1)
test "raises FunctionClauseError exception on non-binary input" do
assert_raise FunctionClauseError, fn -> Instances.reachable?(nil) end
assert_raise FunctionClauseError, fn -> Instances.reachable?(1) end
end
end