From 3b02566e16d33956604815e4bd5190f8f8144253 Mon Sep 17 00:00:00 2001 From: Tusooa Zhu Date: Sat, 9 Apr 2022 23:49:22 -0400 Subject: [PATCH 1/7] Fix tab switcher not working when some tabs hidden --- src/components/tab_switcher/tab_switcher.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/tab_switcher/tab_switcher.jsx b/src/components/tab_switcher/tab_switcher.jsx index f5a1e603..c8d390bc 100644 --- a/src/components/tab_switcher/tab_switcher.jsx +++ b/src/components/tab_switcher/tab_switcher.jsx @@ -50,7 +50,7 @@ export default { activeIndex () { // In case of controlled component if (this.activeTab) { - return this.slots().findIndex(slot => this.activeTab === slot.props.key) + return this.slots().findIndex(slot => slot && slot.props && this.activeTab === slot.props.key) } else { return this.active } From 169d13680a72029cab71067abffbb4581cdb6b41 Mon Sep 17 00:00:00 2001 From: Tusooa Zhu Date: Sun, 10 Apr 2022 13:02:02 -0400 Subject: [PATCH 2/7] Fix image cropper not closing correctly --- src/components/image_cropper/image_cropper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/image_cropper/image_cropper.js b/src/components/image_cropper/image_cropper.js index e72ed0e8..05f6fd4c 100644 --- a/src/components/image_cropper/image_cropper.js +++ b/src/components/image_cropper/image_cropper.js @@ -66,7 +66,7 @@ const ImageCropper = { } }, methods: { - unmounted () { + destroy () { if (this.cropper) { this.cropper.destroy() } From d175e86901dda5b54f7caad744f78f347332f821 Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Tue, 12 Apr 2022 18:10:19 +0300 Subject: [PATCH 3/7] fix hashtags by explicitly putting attributes --- src/components/rich_content/rich_content.jsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/components/rich_content/rich_content.jsx b/src/components/rich_content/rich_content.jsx index 41e287e4..ca075270 100644 --- a/src/components/rich_content/rich_content.jsx +++ b/src/components/rich_content/rich_content.jsx @@ -28,6 +28,10 @@ import './rich_content.scss' */ export default { name: 'RichContent', + components: { + MentionsLine, + HashtagLink + }, props: { // Original html content html: { @@ -86,7 +90,8 @@ export default { if (!encounteredTextReverse) { lastTags.push(linkData) } - return + const { url, tag, content } = linkData + return } const renderMention = (attrs, children) => { From 0bb69d7fe026181bb6367ced8a921d0c3a0dc6ba Mon Sep 17 00:00:00 2001 From: Henry Jameson Date: Tue, 12 Apr 2022 19:04:32 +0300 Subject: [PATCH 4/7] fix tests --- test/unit/specs/components/rich_content.spec.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/unit/specs/components/rich_content.spec.js b/test/unit/specs/components/rich_content.spec.js index a4920867..958fb997 100644 --- a/test/unit/specs/components/rich_content.spec.js +++ b/test/unit/specs/components/rich_content.spec.js @@ -308,10 +308,8 @@ describe('RichContent', () => { '', 'NHCMDUXJPPZ6M3Z2CQ6D2EBRSWGE7MZY.jpg', ' ', - '#nou', '', ' ', - '#screencap', '', '

' ].join('') From a4ea0a30bf02893cea783824c4824a5d1d87ff6c Mon Sep 17 00:00:00 2001 From: Tusooa Zhu Date: Tue, 19 Apr 2022 20:20:18 -0400 Subject: [PATCH 5/7] Fix incorrect close of a status popover when clicking Expand inside it basically Vue (3 in particular?) will make changes to DOM before this event listener is called, and if the target is displayed using v-if, it will not be part of the DOM at that time, and contains() will return false. so it goes to call hidePopover() which caused this bug. --- src/components/status_body/status_body.vue | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/components/status_body/status_body.vue b/src/components/status_body/status_body.vue index 24d842c2..976fe98c 100644 --- a/src/components/status_body/status_body.vue +++ b/src/components/status_body/status_body.vue @@ -15,14 +15,14 @@ :emoji="status.emojis" />