sam/cytube-json-generator
Archived
2
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity

master #2

Merged
sam merged 1 commit from grumbulon/cytube-json-generator:master into master 2024-05-18 21:59:26 +00:00
Conversation 0 Commits 1 Files changed 1 +34
grumbulon commented 2022-05-31 02:02:20 +00:00
Contributor
Copy link

Small and stupid """issue""" when using the script was the title of the video in the JSON file is just the first letter of the argument (ex. Lucky Star Episode 1 etc. title would just be "L"), additionally subtitle name was not unique in the json file (this doesn't really matter I just didn't like it).

Also I wrote a (small) unit test for this change to make sure I didn't break anything.

Small and stupid """issue""" when using the script was the title of the video in the JSON file is just the first letter of the argument (ex. Lucky Star Episode 1 etc. title would just be "L"), additionally subtitle name was not unique in the json file (this doesn't really matter I just didn't like it). Also I wrote a (small) unit test for this change to make sure I didn't break anything.
grumbulon added 2 commits 2022-05-31 02:02:21 +00:00
sam merged commit 428ee0d71c into master 2022-06-04 20:17:52 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sam/cytube-json-generator#2
No description provided.
Delete branch "grumbulon/cytube-json-generator:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?