sam/awl
sam/awl
1
0
Fork 1
Code Issues 5 Pull requests Projects Releases 28 Packages 4 Wiki Activity Actions

fix: EDNS cookies work properly #98

Merged
sam merged 3 commits from fix-edns-cookies into master 2022-09-16 23:26:10 +00:00
Conversation 0 Commits 3 Files changed 17 +93 -32
sam commented 2022-09-16 12:13:39 +00:00
Owner
Copy link

also slight refactors :)

closes #96

also slight refactors :) closes #96
sam added 1 commit 2022-09-16 12:13:40 +00:00
fix: EDNS cookies work properly
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
33cb3e4572 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam added 1 commit 2022-09-16 22:50:23 +00:00
fix dumb mistake
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
80522df153 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam added a new dependency 2022-09-16 22:51:46 +00:00
#96 BADCOOKIE (and other EDNS errors, probably)
sam removed a dependency 2022-09-16 22:55:37 +00:00
#96 BADCOOKIE (and other EDNS errors, probably)
grumbulon requested changes 2022-09-16 22:59:03 +00:00
query/query.go Outdated
@ -44,7 +44,7 @@ func CreateQuery(opts util.Options) (util.Response, error) {
if opts.EDNS.Cookie {
e := new(dns.EDNS0_COOKIE)
grumbulon commented 2022-09-16 21:42:39 +00:00
Collaborator
Copy link

Change e to edns -- single letter variables are good for examples but not for production.

	edns := new(dns.EDNS0_COOKIE)
	edns.Code = dns.EDNS0COOKIE
	edns.Cookie = uniuri.NewLenChars(16, []byte("1234567890abcdef"))
Change e to `edns` -- single letter variables are good for examples but not for production. ```Go edns := new(dns.EDNS0_COOKIE) edns.Code = dns.EDNS0COOKIE edns.Cookie = uniuri.NewLenChars(16, []byte("1234567890abcdef")) ```
sam marked this conversation as resolved
sam added 1 commit 2022-09-16 23:17:21 +00:00
Apply suggested change :)
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
f6bb2c85cd 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam requested review from grumbulon 2022-09-16 23:17:28 +00:00
grumbulon approved these changes 2022-09-16 23:21:19 +00:00
grumbulon left a comment
Collaborator
Copy link

lgtm :)

lgtm :)
sam merged commit 8df0347891 into master 2022-09-16 23:26:10 +00:00
sam deleted branch fix-edns-cookies 2022-09-16 23:26:11 +00:00
sam referenced this pull request from a commit 2022-09-16 23:26:11 +00:00
fix: EDNS cookies work properly (#98)
Sign in to join this conversation.
Reviewers
No reviewers
grumbulon
Labels
Clear labels   
Priority: High

This should be worked on soon

  
Priority: Low

This might get worked on

  
Priority: Medium

This should be worked on eventually

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

I am too lazy to do this myself but I will gladly look at someone else's effort

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
Priority: High
Priority: Low
Priority: Medium
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sam/awl#98
No description provided.
Delete branch "fix-edns-cookies"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?