sam/awl
sam
/
awl
1
0
Fork 1
Code Issues 5 Pull Requests Actions Packages Projects Releases 27 Wiki Activity

refactor: Make all calls to options pointers #132

Merged
sam merged 1 commits from pointerize-things into master 2022-10-13 12:49:37 +00:00
Conversation 1 Commits 1 Files Changed 16 +54 -52
sam commented 2022-10-10 14:05:21 +00:00
Owner
Copy Link

Instead of copying the opts struct every time it gets passed around, it should be created once and passed through reference.

This should reduce memory utilization, unfortunately I cannot test it since this program runs so fast pprof won't report anything useful.

I think I found all of them 🙂

Instead of copying the opts struct every time it gets passed around, it should be created once and passed through reference. This should reduce memory utilization, unfortunately I cannot test it since this program runs so fast pprof won't report anything useful. I think I found all of them 🙂
sam added 1 commit 2022-10-10 14:05:21 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
2a61464e17
refactor: Make all calls to options pointers 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
grumbulon approved these changes 2022-10-12 20:50:04 +00:00
grumbulon commented 2022-10-12 20:50:25 +00:00
Collaborator
Copy Link

good change idea 🙂

good change idea 🙂
sam merged commit 81da49093d into master 2022-10-13 12:49:37 +00:00
sam deleted branch pointerize-things 2022-10-13 12:49:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
grumbulon
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

I am too lazy to do this myself but I will gladly look at someone else's effort

  
invalid

Something is wrong

  
Priority: High

This should be worked on soon

  
Priority: Low

This might get worked on

  
Priority: Medium

This should be worked on eventually

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
Priority: High
Priority: Low
Priority: Medium
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sam/awl#132
No description provided.
Delete Branch "pointerize-things"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?