sam/awl
sam/awl
1
0
Fork 1
Code Issues 5 Pull requests Projects Releases 28 Packages 4 Wiki Activity Actions

refactor: Make all calls to options pointers #132

Merged
sam merged 1 commit from pointerize-things into master 2022-10-13 12:49:37 +00:00
Conversation 1 Commits 1 Files changed 16 +54 -52
sam commented 2022-10-10 14:05:21 +00:00
Owner
Copy link

Instead of copying the opts struct every time it gets passed around, it should be created once and passed through reference.

This should reduce memory utilization, unfortunately I cannot test it since this program runs so fast pprof won't report anything useful.

I think I found all of them 🙂

Instead of copying the opts struct every time it gets passed around, it should be created once and passed through reference. This should reduce memory utilization, unfortunately I cannot test it since this program runs so fast pprof won't report anything useful. I think I found all of them 🙂
sam added 1 commit 2022-10-10 14:05:21 +00:00
refactor: Make all calls to options pointers
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
2a61464e17 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
grumbulon approved these changes 2022-10-12 20:50:04 +00:00
grumbulon commented 2022-10-12 20:50:25 +00:00
Collaborator
Copy link

good change idea 🙂

good change idea 🙂
sam merged commit 81da49093d into master 2022-10-13 12:49:37 +00:00
sam deleted branch pointerize-things 2022-10-13 12:49:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
grumbulon
Labels
Clear labels   
Priority: High

This should be worked on soon

  
Priority: Low

This might get worked on

  
Priority: Medium

This should be worked on eventually

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

I am too lazy to do this myself but I will gladly look at someone else's effort

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
Priority: High
Priority: Low
Priority: Medium
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sam/awl#132
No description provided.
Delete branch "pointerize-things"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?