sam/awl
sam
/
awl
1
0
Fork 1
Code Issues 5 Pull Requests Actions Packages Projects Releases 27 Wiki Activity

feat: add preliminary message tinkering #79

Merged
sam merged 2 commits from feat-res-tinkering into master 2022-09-05 00:05:06 +00:00
Conversation 0 Commits 2 Files Changed 18 +183 -68
sam commented 2022-09-04 23:38:13 +00:00
Owner
Copy Link

There is probably a better way to do this, but it functions.

There is probably a better way to do this, but it functions.
sam added 1 commit 2022-09-04 23:38:13 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
bf870e6289
feat: add preliminary message tinkering 
Is this the right way to do it? Probably not.
Do I care? No.

Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam requested review from grumbulon 2022-09-04 23:38:25 +00:00
grumbulon reviewed 2022-09-04 23:43:01 +00:00
cli/cli_test.go Outdated
@ -85,2 +85,4 @@
func TestInvalidFlag(t *testing.T) { //nolint: paralleltest // Race conditions
old := os.Args
old2 := os.Stdout
old3 := os.Stderr
grumbulon commented 2022-09-04 23:43:01 +00:00
Collaborator
Copy Link

Stylistic nitpick why not

	args := os.Args
	stdout := os.Stdout
	stderr := os.Stderr
Stylistic nitpick why not ```go args := os.Args stdout := os.Stdout stderr := os.Stderr ```
sam marked this conversation as resolved
grumbulon reviewed 2022-09-04 23:53:04 +00:00
query/query.go Outdated
@ -119,3 +119,3 @@
temp := opts.Display.Statistics
opts.Display.Statistics = false
str = ToString(util.Response{
str, err = ToString(util.Response{
grumbulon commented 2022-09-04 23:53:04 +00:00
Collaborator
Copy Link

Also optional style nit

	str, err = ToString(
		util.Response{
			DNS: req,
			RTT: 0,
		},
		opts,
	)
Also optional style nit ```go str, err = ToString( util.Response{ DNS: req, RTT: 0, }, opts, ) ```
sam marked this conversation as resolved
grumbulon approved these changes 2022-09-04 23:57:14 +00:00
sam added 1 commit 2022-09-05 00:01:27 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
6bb1c0a0cb
Apply suggestions 
:)

Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam merged commit 7edd983175 into master 2022-09-05 00:05:06 +00:00
sam deleted branch feat-res-tinkering 2022-09-05 00:05:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
grumbulon
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

I am too lazy to do this myself but I will gladly look at someone else's effort

  
invalid

Something is wrong

  
Priority: High

This should be worked on soon

  
Priority: Low

This might get worked on

  
Priority: Medium

This should be worked on eventually

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
Priority: High
Priority: Low
Priority: Medium
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sam/awl#79
No description provided.
Delete Branch "feat-res-tinkering"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?