sam/awl
sam/awl
1
0
Fork 1
Code Issues 5 Pull requests Projects Releases 28 Packages 4 Wiki Activity Actions

feat: add preliminary message tinkering #79

Merged
sam merged 2 commits from feat-res-tinkering into master 2022-09-05 00:05:06 +00:00
Conversation 0 Commits 2 Files changed 18 +183 -68
sam commented 2022-09-04 23:38:13 +00:00
Owner
Copy link

There is probably a better way to do this, but it functions.

There is probably a better way to do this, but it functions.
sam added 1 commit 2022-09-04 23:38:13 +00:00
feat: add preliminary message tinkering
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
bf870e6289 
Is this the right way to do it? Probably not.
Do I care? No.

Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam requested review from grumbulon 2022-09-04 23:38:25 +00:00
grumbulon reviewed 2022-09-04 23:43:01 +00:00
cli/cli_test.go Outdated
@ -85,2 +85,4 @@
func TestInvalidFlag(t *testing.T) { //nolint: paralleltest // Race conditions
old := os.Args
old2 := os.Stdout
old3 := os.Stderr
grumbulon commented 2022-09-04 23:43:01 +00:00
Collaborator
Copy link

Stylistic nitpick why not

	args := os.Args
	stdout := os.Stdout
	stderr := os.Stderr
Stylistic nitpick why not ```go args := os.Args stdout := os.Stdout stderr := os.Stderr ```
sam marked this conversation as resolved
grumbulon reviewed 2022-09-04 23:53:04 +00:00
query/query.go Outdated
@ -119,3 +119,3 @@
temp := opts.Display.Statistics
opts.Display.Statistics = false
str = ToString(util.Response{
str, err = ToString(util.Response{
grumbulon commented 2022-09-04 23:53:04 +00:00
Collaborator
Copy link

Also optional style nit

	str, err = ToString(
		util.Response{
			DNS: req,
			RTT: 0,
		},
		opts,
	)
Also optional style nit ```go str, err = ToString( util.Response{ DNS: req, RTT: 0, }, opts, ) ```
sam marked this conversation as resolved
grumbulon approved these changes 2022-09-04 23:57:14 +00:00
sam added 1 commit 2022-09-05 00:01:27 +00:00
Apply suggestions
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
6bb1c0a0cb 
:)

Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam merged commit 7edd983175 into master 2022-09-05 00:05:06 +00:00
sam deleted branch feat-res-tinkering 2022-09-05 00:05:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
grumbulon
Labels
Clear labels   
Priority: High

This should be worked on soon

  
Priority: Low

This might get worked on

  
Priority: Medium

This should be worked on eventually

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

I am too lazy to do this myself but I will gladly look at someone else's effort

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
Priority: High
Priority: Low
Priority: Medium
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sam/awl#79
No description provided.
Delete branch "feat-res-tinkering"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?