feat: RFC-8427 #171

Merged

sam merged 16 commits from RFC-8427 into master 2022-12-27 20:07:09 +00:00

Conversation 1 Commits 16 Files Changed 3 +387 -330

grumbulon commented 2022-12-15 23:29:49 +00:00

Collaborator

Copy Link

This PR will make the JSON response body be based off RFC-8427 which will be similar to kdig's JSON output. Below is example output of running awl git.froth.zone -j --no-opt

⚠️ the only outstanding "issue" for this is that currently in the JSON body response rdata does not specify A, AAAA, MX etc. this is defined here

{
   "dateString": "2022-12-15T18:24:05-00:00",
   "dateSeconds": 1671146645,
   "msgLength": 498,
   "id": 19491,
   "opcode": "QUERY",
   "status": "NOERROR",
   "response": true,
   "authoritative": false,
   "truncated": false,
   "RD": true,
   "RA": true,
   "zero": false,
   "authenticatedData": false,
   "checkingDisabled": false,
   "QNAME": "froth.zone.",
   "QTYPE": 1,
   "QTYPEname": "A",
   "QCLASS": 1,
   "QCLASSname": "IN",
   "queryTime": "14.857181ms",
   "server": "1.1.1.1:53 (UDP)",
   "answersRRs": [
     {
       "NAME": "froth.zone.",
       "TYPE": 1,
       "TYPEname": "A",
       "CLASS": 1,
       "CLASSname": "IN",
       "TTL": "849",
       "rdata": "95.216.99.249",
       "RDLENGTH": 4
     }
   ],
   "authorityRRs": [
     {
       "NAME": "froth.zone.",
       "TYPE": 2,
       "TYPEname": "NS",
       "CLASS": 1,
       "CLASSname": "IN",
       "TTL": "75809",
       "rdata": "rin.froth.zone.",
       "RDLENGTH": 6
     },
     ---
     

This PR will make the JSON response body be based off [RFC-8427](https://www.rfc-editor.org/rfc/rfc8427.html) which will be similar to [kdig's](https://www.knot-dns.cz/docs/2.6/html/man_kdig.html) JSON output. Below is example output of running `awl git.froth.zone -j --no-opt` :warning: the only outstanding "issue" for this is that currently in the JSON body response `rdata` does not specify A, AAAA, MX etc. this is defined [here](https://www.rfc-editor.org/rfc/rfc8427.html#section-2.3) ```JSON { "dateString": "2022-12-15T18:24:05-00:00", "dateSeconds": 1671146645, "msgLength": 498, "id": 19491, "opcode": "QUERY", "status": "NOERROR", "response": true, "authoritative": false, "truncated": false, "RD": true, "RA": true, "zero": false, "authenticatedData": false, "checkingDisabled": false, "QNAME": "froth.zone.", "QTYPE": 1, "QTYPEname": "A", "QCLASS": 1, "QCLASSname": "IN", "queryTime": "14.857181ms", "server": "1.1.1.1:53 (UDP)", "answersRRs": [ { "NAME": "froth.zone.", "TYPE": 1, "TYPEname": "A", "CLASS": 1, "CLASSname": "IN", "TTL": "849", "rdata": "95.216.99.249", "RDLENGTH": 4 } ], "authorityRRs": [ { "NAME": "froth.zone.", "TYPE": 2, "TYPEname": "NS", "CLASS": 1, "CLASSname": "IN", "TTL": "75809", "rdata": "rin.froth.zone.", "RDLENGTH": 6 }, --- ```

grumbulon added 7 commits 2022-12-15 23:29:49 +00:00

720dbc5ccb attempt to make json print like kdig (ref RFC-8427)

5e0ca30b2e lint

9226d0cdf0

small things to make more correct ...

Signed-off-by: Sam Therapy <sam@samtherapy.net>

beaa18d6fb lint and stuff

4d1240cc77 lint and stuff

431937d0fe

make time more correct ...

Signed-off-by: Sam Therapy <sam@samtherapy.net>

1d8856c45a

skirt around rdata ...

Signed-off-by: Sam Therapy <sam@samtherapy.net>

grumbulon added 2 commits 2022-12-16 00:23:51 +00:00

7d53d072bb merge master, fix conflicts, declare vars in query/util.go once

55cd300f4c lint

grumbulon added 1 commit 2022-12-16 00:28:40 +00:00

cfc4d09003 oops, accidentally was racist

grumbulon added 1 commit 2022-12-16 00:29:38 +00:00

252e95ee2d oops again

sam added 1 commit 2022-12-17 15:30:08 +00:00

8aad12c7ef

add edns ...

Signed-off-by: Sam Therapy <sam@samtherapy.net>

sam added 1 commit 2022-12-17 15:32:16 +00:00

9f517424d0

make ttl an int if it is an int ...

Signed-off-by: Sam Therapy <sam@samtherapy.net>

sam requested review from sam 2022-12-17 16:24:27 +00:00

sam added 1 commit 2022-12-17 16:53:43 +00:00

b9bf6bd8dc Merge branch 'master' into RFC-8427

sam approved these changes 2022-12-27 16:02:07 +00:00

sam commented 2022-12-27 16:03:50 +00:00

Owner

Copy Link

I think this all looks good

I think this all looks good

sam added 1 commit 2022-12-27 17:07:29 +00:00

53f89ab107

nit: change flag to bit ...

this is in the RFC

Signed-off-by: Sam Therapy <sam@samtherapy.net>

sam approved these changes 2022-12-27 17:08:02 +00:00

sam added 1 commit 2022-12-27 17:24:53 +00:00

461718d1f6

Force a build

sam merged commit d93eccc064 into master 2022-12-27 20:07:09 +00:00

sam deleted branch RFC-8427 2022-12-27 20:07:09 +00:00

sam referenced this issue from a commit 2022-12-27 20:07:10 +00:00

feat: RFC-8427 (#171)

Sign in to join this conversation.

Reviewers

No reviewers

sam

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

I am too lazy to do this myself but I will gladly look at someone else's effort

  

invalid

Something is wrong

  

Priority: High

This should be worked on soon

  

Priority: Low

This might get worked on

  

Priority: Medium

This should be worked on eventually

  

question

More information is needed

  

wontfix

This won't be fixed

No Label

bug

duplicate

enhancement

help wanted

invalid

Priority: High

Priority: Low

Priority: Medium

question

wontfix

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sam/awl#171

No description provided.