sam/awl
sam
/
awl
1
0
Fork 1
Code Issues 5 Pull Requests Actions Packages Projects Releases 27 Wiki Activity

refactor: Add named returns #168

Merged
sam merged 3 commits from named-returns into master 2022-12-17 16:52:50 +00:00
Conversation 2 Commits 3 Files Changed 7 +69 -64
sam commented 2022-12-12 18:55:02 +00:00
Owner
Copy Link

Add some named returns

TODO: Go through all returns and make them named where it makes more sense

Add some named returns TODO: Go through all returns and make them named where it makes more sense
sam added 1 commit 2022-12-12 18:55:02 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
d952d43705
refactor: Add named returns somewhere 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
grumbulon added 2 commits 2022-12-16 04:36:24 +00:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
91969133ff merge master into branch and use named returns better
grumbulon commented 2022-12-16 04:38:51 +00:00
Collaborator
Copy Link

Hi hello, I looked at this and made some changes to use the named return types more like mentioned here

Hi hello, I looked at this and made some changes to use the named return types more like mentioned [here](https://go.dev/doc/effective_go#named-results)
sam changed title from WIP: refactor: Add named returns to refactor: Add named returns 2022-12-17 16:22:25 +00:00
sam commented 2022-12-17 16:23:20 +00:00
Author
Owner
Copy Link

I can't approve this because it is my own PR but I approve it

I can't approve this because it is my own PR but I approve it
sam requested review from grumbulon 2022-12-17 16:23:25 +00:00
grumbulon approved these changes 2022-12-17 16:49:38 +00:00
sam merged commit fdba9a0a41 into master 2022-12-17 16:52:50 +00:00
sam deleted branch named-returns 2022-12-17 16:52:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
grumbulon
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

I am too lazy to do this myself but I will gladly look at someone else's effort

  
invalid

Something is wrong

  
Priority: High

This should be worked on soon

  
Priority: Low

This might get worked on

  
Priority: Medium

This should be worked on eventually

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
Priority: High
Priority: Low
Priority: Medium
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sam/awl#168
No description provided.
Delete Branch "named-returns"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?