sam/awl
sam
/
awl
1
0
Fork 1
Code Issues 5 Pull Requests Actions Packages Projects Releases 27 Wiki Activity

feat: Trace #162

Merged
sam merged 8 commits from trace into master 2022-12-10 17:51:50 +00:00
Conversation 0 Commits 8 Files Changed 9 +190 -66
sam commented 2022-12-06 21:41:20 +00:00
Owner
Copy Link

This PR should add the trace option, used by +trace and --trace

TODO

  • Making the trace work properly
  • Documentation adding
  • Completion adding
This PR should add the trace option, used by +trace and --trace TODO - [x] Making the trace work properly - [x] Documentation adding - [x] Completion adding
sam added 1 commit 2022-12-06 21:41:21 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
4ae8471580
fix(errors): put exported errors in util 
IMO it is better to centralize them

Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam force-pushed trace from fbe69d91c2 to cd09ae9137 2022-12-06 21:45:26 +00:00 Compare
sam changed title from WIP: feat: Trace to feat: Trace 2022-12-06 21:45:34 +00:00
sam changed title from feat: Trace to WIP: feat: Trace 2022-12-06 21:45:38 +00:00
sam changed title from WIP: feat: Trace to feat: Trace 2022-12-09 15:22:50 +00:00
sam force-pushed trace from bea1b8e32f to 9e22c2b145 2022-12-09 15:22:56 +00:00 Compare
sam changed title from feat: Trace to WIP: feat: Trace 2022-12-09 15:23:03 +00:00
sam added 1 commit 2022-12-09 15:35:13 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
5b058125ae
add tests 
Co-authored-by: grumbulon <grumbulon@grumbulon.xyz>
Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam added 1 commit 2022-12-09 15:55:39 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
23af5c66d0
docs + completions 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam changed title from WIP: feat: Trace to feat: Trace 2022-12-09 15:56:05 +00:00
sam added 1 commit 2022-12-09 16:23:13 +00:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
740f0e6082
fix tracing forever if tracing the root 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
grumbulon requested changes 2022-12-09 23:19:13 +00:00
main.go Outdated
@ -67,0 +91,4 @@
fmt.Println(str)
if keepTracing {
var nothing []dns.RR
grumbulon commented 2022-12-09 23:19:00 +00:00
Collaborator
Copy Link

Maybe name this something that isn't nothing, same with nothing2

Maybe name this something that isn't `nothing`, same with `nothing2`
sam commented 2022-12-10 14:09:52 +00:00
Author
Owner
Copy Link

changed :)

changed :)
👍 1
grumbulon marked this conversation as resolved
sam added 1 commit 2022-12-10 14:07:29 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
a38a03c959
use better variable names 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
sam requested review from grumbulon 2022-12-10 14:12:38 +00:00
grumbulon approved these changes 2022-12-10 17:43:18 +00:00
sam merged commit 530ef06ee1 into master 2022-12-10 17:51:50 +00:00
sam deleted branch trace 2022-12-10 17:51:50 +00:00
sam referenced this issue from a commit 2022-12-10 17:51:50 +00:00
feat: Trace (#162)
Sign in to join this conversation.
Reviewers
No reviewers
grumbulon
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

I am too lazy to do this myself but I will gladly look at someone else's effort

  
invalid

Something is wrong

  
Priority: High

This should be worked on soon

  
Priority: Low

This might get worked on

  
Priority: Medium

This should be worked on eventually

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
Priority: High
Priority: Low
Priority: Medium
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sam/awl#162
No description provided.
Delete Branch "trace"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?