From c8282e803049fba5f5eef3acfd363ac17229f3cd Mon Sep 17 00:00:00 2001
From: Sam <sam@samtherapy.net>
Date: Fri, 9 Sep 2022 12:59:49 +0000
Subject: [PATCH] fix: make retries actually work properly (#88)

Reviewed-on: https://git.froth.zone/sam/awl/pulls/88
Reviewed-by: grumbulon <grumbulon@grumbulon.xyz>
---
 cli/dig.go          |  2 +-
 completions/zsh.zsh |  4 ++--
 go.sum              | 10 ----------
 main.go             |  4 ++--
 4 files changed, 5 insertions(+), 15 deletions(-)

diff --git a/cli/dig.go b/cli/dig.go
index 6194e81..6d75b6c 100644
--- a/cli/dig.go
+++ b/cli/dig.go
@@ -159,7 +159,7 @@ func parseDigEq(startNo bool, arg string, opts *util.Options) error {
 
 			// TODO: Is there a better way to do this?
 			if arg == "tries" {
-				opts.Request.Retries++
+				opts.Request.Retries--
 			}
 		} else {
 			return fmt.Errorf("digflags: retry: %w", errNoArg)
diff --git a/completions/zsh.zsh b/completions/zsh.zsh
index 167ee50..8463dbf 100644
--- a/completions/zsh.zsh
+++ b/completions/zsh.zsh
@@ -33,7 +33,7 @@ local -a alts args
   '*+'{no,}'identify[print IP and port of responder]'
   '*+'{no,}'comments[print comment lines in output]'
   '*+'{no,}'stats[print statistics]'
-  '*+padding[set padding block size]:size [0]'
+  '*+padding[set padding block size]'
   '*+'{no,}'qr[print query as it was sent]'
   '*+'{no,}'question[print question section of a query]'
   '*+'{no,}'raflag[set RA flag in the query]'
@@ -74,7 +74,7 @@ _arguments -s -C $args \
   '*-6+[force IPv6 only]' \
   '*-'{x,-reverse}'+[reverse lookup]' \
   '*--timeout+[timeout in seconds]:number [1]' \
-  '*--retry+[specify number of UDP query retries]:number [2]' \
+  '*--retries+[specify number of query retries]:number [2]' \
   '*--no-edns+[disable EDNS]' \
   '*--edns-ver+[specify EDNS version for query]:version (0-255) [0]' \
   '*-'{D,-dnssec}'+[enable DNSSEC]' \
diff --git a/go.sum b/go.sum
index 44ea107..92ce510 100644
--- a/go.sum
+++ b/go.sum
@@ -77,8 +77,6 @@ github.com/yuin/goldmark v1.3.5/go.mod h1:mwnBkeHKe2W/ZEtQ+71ViKU8L12m81fl3OWwC1
 golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
 golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
 golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
-golang.org/x/crypto v0.0.0-20220826181053-bd7e27e6170d h1:3qF+Z8Hkrw9sOhrFHti9TlB1Hkac1x+DNRkv0XQiFjo=
-golang.org/x/crypto v0.0.0-20220826181053-bd7e27e6170d/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=
 golang.org/x/crypto v0.0.0-20220829220503-c86fa9a7ed90 h1:Y/gsMcFOcR+6S6f3YeMKl5g+dZMEWqcz5Czj/GWYbkM=
 golang.org/x/crypto v0.0.0-20220829220503-c86fa9a7ed90/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=
 golang.org/x/exp v0.0.0-20220827204233-334a2380cb91 h1:tnebWN09GYg9OLPss1KXj8txwZc6X6uMr6VFdcGNbHw=
@@ -94,10 +92,6 @@ golang.org/x/net v0.0.0-20200520004742-59133d7f0dd7/go.mod h1:qpuaurCH72eLCgpAm/
 golang.org/x/net v0.0.0-20201021035429-f5854403a974/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
 golang.org/x/net v0.0.0-20210405180319-a5a99cb37ef4/go.mod h1:p54w0d4576C0XHj96bSt6lcn1PtDYWL6XObtHCRCNQM=
 golang.org/x/net v0.0.0-20210726213435-c6fcb2dbf985/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
-golang.org/x/net v0.0.0-20220826154423-83b083e8dc8b h1:ZmngSVLe/wycRns9MKikG9OWIEjGcGAkacif7oYQaUY=
-golang.org/x/net v0.0.0-20220826154423-83b083e8dc8b/go.mod h1:YDH+HFinaLZZlnHAfSS6ZXJJ9M9t4Dl22yv3iI2vPwk=
-golang.org/x/net v0.0.0-20220906165146-f3363e06e74c h1:yKufUcDwucU5urd+50/Opbt4AYpqthk7wHpHok8f1lo=
-golang.org/x/net v0.0.0-20220906165146-f3363e06e74c/go.mod h1:YDH+HFinaLZZlnHAfSS6ZXJJ9M9t4Dl22yv3iI2vPwk=
 golang.org/x/net v0.0.0-20220907135653-1e95f45603a7 h1:1WGATo9HAhkWMbfyuVU0tEFP88OIkUvwaHFveQPvzCQ=
 golang.org/x/net v0.0.0-20220907135653-1e95f45603a7/go.mod h1:YDH+HFinaLZZlnHAfSS6ZXJJ9M9t4Dl22yv3iI2vPwk=
 golang.org/x/sync v0.0.0-20180314180146-1d60e4601c6f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
@@ -121,10 +115,6 @@ golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7w
 golang.org/x/sys v0.0.0-20210510120138-977fb7262007/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20220412211240-33da011f77ad/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.0.0-20220829200755-d48e67d00261 h1:v6hYoSR9T5oet+pMXwUWkbiVqx/63mlHjefrHmxwfeY=
-golang.org/x/sys v0.0.0-20220829200755-d48e67d00261/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.0.0-20220906165534-d0df966e6959 h1:qSa+Hg9oBe6UJXrznE+yYvW51V9UbyIj/nj/KpDigo8=
-golang.org/x/sys v0.0.0-20220906165534-d0df966e6959/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20220907062415-87db552b00fd h1:AZeIEzg+8RCELJYq8w+ODLVxFgLMMigSwO/ffKPEd9U=
 golang.org/x/sys v0.0.0-20220907062415-87db552b00fd/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20220908164124-27713097b956 h1:XeJjHH1KiLpKGb6lvMiksZ9l0fVUh+AmGcm0nOMEBOY=
diff --git a/main.go b/main.go
index db41dea..bf737af 100644
--- a/main.go
+++ b/main.go
@@ -36,11 +36,11 @@ func run() (opts util.Options, code int, err error) {
 	var resp util.Response
 
 	// Retry queries if a query fails
-	for i := 0; i < opts.Request.Retries; i++ {
+	for i := 0; i <= opts.Request.Retries; i++ {
 		resp, err = query.CreateQuery(opts)
 		if err == nil {
 			break
-		} else {
+		} else if i != opts.Request.Retries {
 			opts.Logger.Warn("Retrying request, error:", err)
 		}
 	}
