From b3485924d6437f197fa83ffb2f34d86eb1c9dbfe Mon Sep 17 00:00:00 2001 From: Sam Therapy Date: Thu, 22 Sep 2022 00:59:31 +0200 Subject: [PATCH] Code review :) Signed-off-by: Sam Therapy --- conf/plan9_test.go | 51 ---------------------------------------------- go.sum | 14 ------------- 2 files changed, 65 deletions(-) diff --git a/conf/plan9_test.go b/conf/plan9_test.go index d34c54b..dbf01f9 100644 --- a/conf/plan9_test.go +++ b/conf/plan9_test.go @@ -23,54 +23,3 @@ func TestPlan9Config(t *testing.T) { assert.NilError(t, err) assert.Assert(t, len(conf.Servers) != 0) } - -// Old config grabber tests -// func TestGetValidPlan9Config(t *testing.T) { -// t.Parallel() - -// if runtime.GOOS != "plan9" { -// t.Skip("Not running Plan 9, skipping") -// } - -// ndbs := []struct { -// in string -// want string -// }{ -// {`ip=192.168.122.45 ipmask=255.255.255.0 ipgw=192.168.122.1 -// sys=chog9 -// dns=192.168.122.1`, "192.168.122.1"}, -// {`ipnet=murray-hill ip=135.104.0.0 ipmask=255.255.0.0 -// dns=135.104.10.1 -// ntp=ntp.cs.bell-labs.com -// ipnet=plan9 ip=135.104.9.0 ipmask=255.255.255.0 -// ntp=oncore.cs.bell-labs.com -// smtp=smtp1.cs.bell-labs.com -// ip=135.104.9.6 sys=anna dom=anna.cs.bell-labs.com -// smtp=smtp2.cs.bell-labs.com`, "135.104.10.1"}, -// } - -// for _, ndb := range ndbs { -// // Go is a little quirky -// ndb := ndb - -// t.Run(ndb.want, func(t *testing.T) { -// t.Parallel() - -// act, err := conf.GetDNSConfig(ndb.in) -// assert.NilError(t, err) -// assert.Equal(t, ndb.want, act.Servers[0]) -// }) -// } -// } - -// func TestInvalidPlan9Config(t *testing.T) { -// invalid := `sys = spindle -// dom=spindle.research.bell-labs.com -// bootf=/mips/9powerboot -// ip=135.104.117.32 ether=080069020677 -// proto=il` - -// act, err := conf.GetDNSConfig(invalid) -// assert.ErrorContains(t, err, "no DNS servers found") -// assert.Assert(t, act == nil) -// } diff --git a/go.sum b/go.sum index 3fa391b..055ae3b 100644 --- a/go.sum +++ b/go.sum @@ -92,16 +92,6 @@ golang.org/x/net v0.0.0-20200520004742-59133d7f0dd7/go.mod h1:qpuaurCH72eLCgpAm/ golang.org/x/net v0.0.0-20201021035429-f5854403a974/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU= golang.org/x/net v0.0.0-20210405180319-a5a99cb37ef4/go.mod h1:p54w0d4576C0XHj96bSt6lcn1PtDYWL6XObtHCRCNQM= golang.org/x/net v0.0.0-20210726213435-c6fcb2dbf985/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y= -golang.org/x/net v0.0.0-20220909164309-bea034e7d591 h1:D0B/7al0LLrVC8aWF4+oxpv/m8bc7ViFfVS8/gXGdqI= -golang.org/x/net v0.0.0-20220909164309-bea034e7d591/go.mod h1:YDH+HFinaLZZlnHAfSS6ZXJJ9M9t4Dl22yv3iI2vPwk= -golang.org/x/net v0.0.0-20220919171627-f8f703f97925 h1:5Vhms/MnzRfom2tX/lHt58o74fzobhcw2FDjPdoGoow= -golang.org/x/net v0.0.0-20220919171627-f8f703f97925/go.mod h1:YDH+HFinaLZZlnHAfSS6ZXJJ9M9t4Dl22yv3iI2vPwk= -golang.org/x/net v0.0.0-20220919232410-f2f64ebce3c1 h1:TWZxd/th7FbRSMret2MVQdlI8uT49QEtwZdvJrxjEHU= -golang.org/x/net v0.0.0-20220919232410-f2f64ebce3c1/go.mod h1:YDH+HFinaLZZlnHAfSS6ZXJJ9M9t4Dl22yv3iI2vPwk= -golang.org/x/net v0.0.0-20220920203100-d0c6ba3f52d9 h1:asZqf0wXastQr+DudYagQS8uBO8bHKeYD1vbAvGmFL8= -golang.org/x/net v0.0.0-20220920203100-d0c6ba3f52d9/go.mod h1:YDH+HFinaLZZlnHAfSS6ZXJJ9M9t4Dl22yv3iI2vPwk= -golang.org/x/net v0.0.0-20220921155015-db77216a4ee9 h1:SdDGdqRuKrF2R4XGcnPzcvZ63c/55GvhoHUus0o+BNI= -golang.org/x/net v0.0.0-20220921155015-db77216a4ee9/go.mod h1:YDH+HFinaLZZlnHAfSS6ZXJJ9M9t4Dl22yv3iI2vPwk= golang.org/x/net v0.0.0-20220921203646-d300de134e69 h1:hUJpGDpnfwdJW8iNypFjmSY0sCBEL+spFTZ2eO+Sfps= golang.org/x/net v0.0.0-20220921203646-d300de134e69/go.mod h1:YDH+HFinaLZZlnHAfSS6ZXJJ9M9t4Dl22yv3iI2vPwk= golang.org/x/sync v0.0.0-20180314180146-1d60e4601c6f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= @@ -125,10 +115,6 @@ golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7w golang.org/x/sys v0.0.0-20210510120138-977fb7262007/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.0.0-20220412211240-33da011f77ad/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= -golang.org/x/sys v0.0.0-20220913175220-63ea55921009 h1:PuvuRMeLWqsf/ZdT1UUZz0syhioyv1mzuFZsXs4fvhw= -golang.org/x/sys v0.0.0-20220913175220-63ea55921009/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= -golang.org/x/sys v0.0.0-20220915200043-7b5979e65e41 h1:ohgcoMbSofXygzo6AD2I1kz3BFmW1QArPYTtwEM3UXc= -golang.org/x/sys v0.0.0-20220915200043-7b5979e65e41/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.0.0-20220919091848-fb04ddd9f9c8 h1:h+EGohizhe9XlX18rfpa8k8RAc5XyaeamM+0VHRd4lc= golang.org/x/sys v0.0.0-20220919091848-fb04ddd9f9c8/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=