mirrors/dnscrypt
1
0
Fork 0
mirror of https://github.com/SamTherapy/dnscrypt.git synced 2024-11-21 05:13:46 +00:00
Code Activity

all: fix another panic in cert parsing (#21)

Browse source 
Fixes #20.
This commit is contained in:
Ainar Garipov 2023-04-13 16:24:15 +03:00 committed by GitHub
parent 6ca80e7ffc
commit d84a81e12d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
client.go
View file

@ -79,7 +79,9 @@ func (c *Client) DialStamp(stamp dnsstamps.ServerStamp) (*ResolverInfo, error) {
if err != nil {
return nil, err
}
resolverInfo.SharedKey = sharedKey
return resolverInfo, nil
}
@ -251,7 +253,10 @@ func (c *Client) fetchCert(stamp dnsstamps.ServerStamp) (cert *Cert, err error)
cert, err = parseCert(stamp, currentCert, providerName, strings.Join(txt.Txt, ""))
if err != nil {
log.Debug("[%s] bad cert: %s", providerName, err)
continue
} else if cert == nil {
// The certificate has been skipped due to Serial or EsVersion.
continue
}
@ -262,7 +267,7 @@ func (c *Client) fetchCert(stamp dnsstamps.ServerStamp) (cert *Cert, err error)
if foundValid {
return currentCert, nil
} else if err == nil {
err = errors.Error("no valid txt records")
err = fmt.Errorf("no valid txt records for provider %q", providerName)
}
return nil, err